refactor: Webpack Defaults 2.x merge #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: Update node versions for new LTS * refactor: Use non-deprecated config type * refactor: Prettier & CircleCI initial conversion - Leverages Prettier to manage code style - Migrates to eslint-config-webpack 2.x ( Prettier support) - Updates code style per the above - Adds contrib standard testing config - Installs schema utils dependency - Creates `options.json` template - Updates Node versions to current LTS - Moves to non-deprecated eslint config format - Migrates to CircleCI & a full continuous delivery workflow BREAKING CHANGE: Drops support for NodeJS 4.x BREAKING CHANGE: Implements Prettier & modifies suported Eslint configuration that transfers applicable rule responsibility to Prettier BREAKING CHANGE: Drops TravisCI in favor of CircleCI 2.0 BREAKING CHANGE: Drops support for Webpack 2.x BREAKING CHANGE: Enforces existing commit message format in pre-commit as it's required for release automation
joshwiens
changed the title
|
Partial Review #86 I will review this later in depth (1-2 days) after I tried it out on a new dummy project (Setup) and on 1-2 current |
- Patch only coverage - Will not comment in PRs
* refactor: Clean up initial loader templates * chore(package): Adds user meta packages * refactor: Consistant pacakge template generation * test: Adds error validation test * refactor: FIxes urls & truncates exection command * docs(readme): Updates usage instructions for script change * refactor: Shorten existing package variable * refactor: Update example options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack-defaults2.x Working branchCODEOWNERStemplateSubject
Body
Migration 1.x.x => 2.x:
package.json: Delete all non-project specificdevDependenciespackage.json: Delete all npm scripts less"webpack-defaults": "webpack-defaults"npm install webpack-defaults@next: Install defaults 2.xnpm run webpack-defaults: Upgrade to the latest defaults.eslintrc: Transfer any custom rules to the rules object in.eslintrc.jsafter the prettier config array.eslintrc: Remove this file.travis.yml: Remove this filepackage-lock.json: Delete this filenpm install: Install updated dependencies & regenerate lock filerequiredvalidations in project settingsCLAcheck &CodecovOutput of defaults beta.0 is visible in webpack-contrib/babel-minify-webpack-plugin#70